Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add normalise function for CuArrays #981

Closed
wants to merge 1 commit into from
Closed

add normalise function for CuArrays #981

wants to merge 1 commit into from

Conversation

rajuthegr8
Copy link

No description provided.

@rajuthegr8 rajuthegr8 mentioned this pull request Jan 1, 2020
Closed
@rajuthegr8
Copy link
Author

This solves #887

@CarloLucibello
Copy link
Member

Hi,
#887 is better fixed by adding std and var specializations to CuArrays.jl, see JuliaGPU/CuArrays.jl#411.
Also, it needs to be extended to support multi-dimensional reductions (e.g. dims=(1,2)) and you should add some tests.

@MikeInnes
Copy link
Member

Yes, this should definitely live in CuArrays rather than here. Best to open a patch on CuArrays and get feedback over there. Thanks for the effort though!

@MikeInnes MikeInnes closed this Jan 3, 2020
@rajuthegr8 rajuthegr8 mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajuthegr8 @CarloLucibello @MikeInnes