Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit train!, unify update!, and auto-translate the two Adams #2082

Merged
merged 18 commits into from
Nov 20, 2022
Merged

Add explicit train!, unify update!, and auto-translate the two Adams #2082

merged 18 commits into from
Nov 20, 2022

Commits on Nov 18, 2022

  1. explicit train, take 2

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c20fb9e View commit details
    Browse the repository at this point in the history

  2. remove train_autodiff macro

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    9c22c11 View commit details
    Browse the repository at this point in the history

  3. make it stricter, to avoid batchmaybe weirdness

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    fa022b3 View commit details
    Browse the repository at this point in the history

  4. remove 3-argument train! since this requires impure loss function, an… 

    …d you can just use update! instead really.
    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    4e937df View commit details
    Browse the repository at this point in the history

  5. remove issingletontype purity check, too strict

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    36a2bb5 View commit details
    Browse the repository at this point in the history

  6. tidy up

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    28a7718 View commit details
    Browse the repository at this point in the history

  7. fix tests

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    5d74b04 View commit details
    Browse the repository at this point in the history

  8. use _old_to_new in Optimisers.setup too

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    7eaf3ea View commit details
    Browse the repository at this point in the history

  9. oops

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    f3e1559 View commit details
    Browse the repository at this point in the history

  10. return nothing

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    63ad543 View commit details
    Browse the repository at this point in the history

  11. test NaN + error, tidy up

    @mcabbott
    mcabbott committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2bd0dad View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. fix test

    @mcabbott
    mcabbott committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    20326ea View commit details
    Browse the repository at this point in the history

  2. remove 2 vs 3 argument comment from docstring

    @mcabbott
    mcabbott committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    db2a9b9 View commit details
    Browse the repository at this point in the history

  3. nice errors for update! with mixed-up input

    @mcabbott
    mcabbott committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    c617807 View commit details
    Browse the repository at this point in the history

  4. fix doctest by making "using Statistics" explicit

    @mcabbott
    mcabbott committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    0389de3 View commit details
    Browse the repository at this point in the history

  5. also delete Flux.params() from the example completely

    @mcabbott
    mcabbott committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    732fa13 View commit details
    Browse the repository at this point in the history

  6. fix

    @mcabbott
    mcabbott committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    d9699c0 View commit details
    Browse the repository at this point in the history

  7. fix

    @mcabbott
    mcabbott committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    db7ad43 View commit details
    Browse the repository at this point in the history