cmake: export targets #943
Conversation
|
There are two other changes on this second version: and Library dependencies are transitive by default with the original signature. When the library target is linked into another target then the libraries linked to this target also were linked to the other targets. That means over-linking for the downstream projects. With the PRIVATE option, the libfluidsynth linked libraries are not included in the I'm afraid that this messed up some tests. Sorry! |
|
The most recent push has messed up the commit history. Can you please clean it up? The unit tests are built against |
pedrolcl
force-pushed
the
wip-cmake-export-targets
branch
from
4f8f9a9 to
43d9c86
Compare
done.
I've reverted the changes to the target_link_libraries() because it is not really related to the exported/imported targets, but it is a preexisting issue. The solution that you propose would work, simply applying target_link_libraries(libfluidsynth-OBJ ...) that will propagate the dependencies to the targets where this object library is linked. The only problem with that is that requires cmake 3.12 or later. See: https://cmake.org/cmake/help/latest/command/target_link_libraries.html?highlight=target_link_library#linking-object-libraries |
The build system creates two exported targets: - The executable FluidSynth::fluidsynth - The library FluidSynth::libfluidsynth A downstream project using CMake can find and link the library target directly with cmake (without needing pkg-config) this way: ~~~ project(sample LANGUAGES C) find_package ( FluidSynth ) if (FluidSynth_FOUND) add_executable( sample sample.c ) target_link_libraries ( sample PRIVATE FluidSynth::libfluidsynth ) endif () ~~~ After installing fluidsynth in a prefix like "$HOME/Fluidsynth3": cmake -DCNAKE_PREFIX_PATH="$HOME/Fluidsynth3/;..." Instead installing, the build directory can be used directly, for instance: cmake -DFluidSynth_DIR="$HOME/fluidsynth-2.2.2/build/" ...
* FluidSynthConfigVersion.cmake is created with ${VERSION} instead of
${LIB_VERSION_INFO}
* FluidSynthConfig.cmake.in simplified: it doesn't need to include the
version file.
* Simplified BUILD_INTERFACE generator expression as suggested
pedrolcl
force-pushed
the
wip-cmake-export-targets
branch
from
25953bc to
f023d7e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
…argets Reverts most of #943 on master as it accidentally broke compilation with CMake < 3.11, but keep the build files for OBS.
The build system creates two exported targets:
A downstream project using CMake can find and link the library target
directly with cmake (without needing pkg-config) this way:
After installing fluidsynth in a prefix like "$HOME/Fluidsynth3":
cmake -DCNAKE_PREFIX_PATH="$HOME/Fluidsynth3/;..."
Instead installing, the build directory can be used directly, for
instance:
cmake -DFluidSynth_DIR="$HOME/fluidsynth-2.2.2/build/" ...