Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fluid log #443

Merged
merged 9 commits into from
Oct 16, 2018
Merged

Fix fluid log #443

merged 9 commits into from
Oct 16, 2018

Conversation

carlo-bramini
Copy link
Contributor

For people who wants to strip a bit the size of the binary, it is possible to reduce the size of the executable by commenting the content of the FLUID_LOG macro. However, I discovered that there are some points in the code that are calling directly the function fluid_log() instead of using FLUID_LOG macro. So, this patch fixes the sources that still need to replace fluid_log() with FLUID_LOG macro.

@derselbst
Copy link
Member

You forgot the explanatory comment at the definition of the FLUID_LOG macro.

@carlo-bramini
Copy link
Contributor Author

Sorry, I had understood that the explanatory comment had to be only in the GIT log. I will do it.

Implements FLUID_LOG with optional checks to current compiler support.
@derselbst
Copy link
Member

Moving FLUID_LOG to fluid_sys.h breaks the unit tests. I would prefer to keep it in fluidsynth_priv.h. Also: Have you considered #define FLUID_LOG (void)sizeof?

@derselbst derselbst merged commit ebc177f into FluidSynth:master Oct 16, 2018
@carlo-bramini carlo-bramini deleted the fix-fluid-log branch October 20, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants