Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel fine tune RPN to use correct range of +/- 100 cent #187

Merged
merged 1 commit into from
Aug 5, 2017

Conversation

mawe42
Copy link
Member

@mawe42 mawe42 commented Aug 5, 2017

FluidSynth currently uses +/- 50 cent for the channel fine tune range. But the MIDI standard defines channel fine tune as follows:

RPN 01 - FINE TUNING:
Resolution: 100/8192 cents
Range: 100/8192* (-8192) to 100/8192* (+8191)
Control Value Displacement in cents from A440
MSB LSB
00 00 100/8192* (-8192)
40H 00 100/8192* (0)
7FH 7FH 100/8192* (+8191)

This change brings FluidSynth in line with the specs.

@derselbst
Copy link
Member

Hm, looks uncomplicated, obvious and non side effect prone. What a welcome change, thanks!

@derselbst derselbst merged commit 7bd07af into FluidSynth:master Aug 5, 2017
@mawe42 mawe42 deleted the fine-tune-range branch October 24, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants