Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make settings more pleasing, natural and subtler #1287

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Make settings more pleasing, natural and subtler #1287

merged 4 commits into from
Jan 2, 2024

Conversation

es20490446e
Copy link
Contributor

@es20490446e es20490446e commented Nov 28, 2023 •
edited
Loading

Demos:

@es20490446e es20490446e mentioned this pull request Nov 28, 2023
Closed
@es20490446e es20490446e changed the title Make chorus and reverb more pleasing, natural and subtler Make settings more pleasing, natural and subtler Dec 2, 2023
@derselbst derselbst added this to the 2.4 milestone Dec 10, 2023
@derselbst derselbst linked an issue Dec 10, 2023 that may be closed by this pull request
Make settings more pleasing, natural and subtler #1282
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

derselbst
derselbst approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally had some time coming back to this. I did some listening tests myself and quite like result. Thank you!

I've also added the previous default settings to the documentation, just in case...

@derselbst derselbst merged commit bd04f3f into FluidSynth:master Jan 2, 2024
44 of 54 checks passed
@es20490446e
Copy link
Contributor Author

Thanks!

A Christmas present for the audiophile of old-school midis 😁🎹

@derselbst derselbst mentioned this pull request Oct 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derselbst derselbst derselbst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

Make settings more pleasing, natural and subtler
2 participants
@es20490446e @derselbst