Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert XG System ON message parsing change #1195

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

derselbst
Copy link
Member

It seems to break the drum channel of too many MIDI files, see discussion in #1092. Instead, document the non-standard handling of this message.

Resolves #1092

@derselbst derselbst added the bug label Dec 20, 2022
@derselbst derselbst added this to the 2.3 milestone Dec 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@derselbst derselbst merged commit dbdae0b into master Dec 23, 2022
@derselbst derselbst deleted the fix-xg-systemon-regression branch December 23, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected XG System ON sysex message is wrong
1 participant