Port the Sequencer to C++11 #1011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing elements from a vector while using iterators to loop over its elements results in crash.
MrSapps
reviewed
Dec 23, 2021
| fluid_event_callback_t callback; | ||
| void *data; | ||
| } fluid_sequencer_client_t; | ||
|
|
||
| /* Private data for SEQUENCER */ | ||
| struct _fluid_sequencer_t |
There was a problem hiding this comment.
prob want to add "final" to these struct _fluid_sequencer_t final
There was a problem hiding this comment.
Maybe, I'll think about it.
MrSapps
reviewed
Dec 23, 2021
MrSapps
reviewed
Dec 23, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP-like example of how a port of fluidsynth to C++11 may look like. See related discussion #847.
TODOs
extern Ccrap to fix MacOS buildfluid_seq_queuestd::find_ifcode duplicationUpdate: In the discussion I mentioned that porting to C++ will keep the API stable. This may not completely hold true:
char*– in C++ this function must return aconst char*(must have)void– since in C++ an exception may be thrown pretty much everywhere, it would be helpful when those functions would return FLUID_OK / FLUID_FAILED (nice-to-have though)However, I'd consider those API changes to be pretty cosmetic though.