-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Bedrock LLM and Embeddings #821
Conversation
feel free to Mark it as Ready for Review when the refractor is done! |
Hey Henry, my understanding is that the project is MIT licensed. I don't understand why you're asking us to sign an SAP contributor license. Can you clarify? Also, the MIT license is a liberal license, so the rights being requested in that agreement are (from what I can tell) already granted by MIT. I'd like to be able to contribute to this project without getting lawyers involved. |
When setting up the project, we just thought of following what others open source project has done with the CLA. But as we have more PR coming in, we also started to realize there is no real needs for that since this is already a MIT licensed project. This was raised a couple of times, and now we have finally taken this CLA off. It will only be reflected for new incoming PR, so you'll probably have to open a new PR, or we can stick to this one, just ignore the CLA message. Edit: CLA has been removed, and no longer appears as one of the checks for PR |
Hey @arneschreuder, a friend of mine @brnkrygs created a new branch in my repo (link below) that uses the underlying langchain class as you suggest. I agree that it's the right way to go. We found a bug that we are tracking down in that code that results in the Claude Model results being cut off. It's possible that it's because Flowing uses v128 instead of the newer v135 but we need to determine that. If you'd like to help, we'd love to have you help us track down why that is. The Titan models seem to work well so if you are good with Titan than you might be ok with Brian's branch. Once we get this fixed we will issue another pull request using the langchain base class. https://github.com/mlconnor/Flowise/tree/feature/langchain-bedrock-llm |
Hi folks! Thanks for the teamwork on getting Bedrock support into Flowise! Looks like recent updates to Langchain have gotten the right bugs fixed, and include Bedrock GA SDK updates. I have a separate fork at the moment off of the head of Flowise:main that drops this support into place. Rather than splinter off into new work, I'm going to see if I can get this fork/branch cleaned up/updated to make a clean merge possible. Expect an update on this PR today! |
That's great news @brnkrygs. Please do not hesitate to reach out if we can help with anything. We are quite excited for this. |
Thanks for the effort! Hopefully this can get it in before the webinar on 8th! |
Note: stop sequences parameter not yet implemented.
Alright, the cleaned up commits here should add:
Hopefully the langchain hooks will help Flowise stay updated without too much extra work! My local tests are working, but I don't have enough access to all supported integrations to do a full manual regression. Also, note that If that's a blocker, feel free to grab this and augment. Otherwise I'll look for time later in the week to work on it. Happy to chase |
Ill review for us. I think we can add stopSequences in a next iteration. I think it is more important to just get Bedrock capabilities in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look correct to me. At some later point we can read the regions, models and different dynamic elements from the AWS API/Site. But this is good enough for now in my opinion.
A note for future updates too: Embeddings. Langchainjs doesn't yet have Bedrock Embeddings support. Chasing that down to see what progress might be underway. Might want to rename this PR to reflect this fact. |
This is great! We can have a separate PR to update the |
AWS Bedrock LLM and Embeddings
This PR is to include the AWS LLM and Embeddings for Amazon Bedrock. A couple of callouts and limitations...