Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ChatOpenAI_ChatModels to include stopSequence parameter #3388

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Refactor ChatOpenAI_ChatModels to include stopSequence parameter #3388

merged 4 commits into from
Oct 21, 2024

Conversation

definitelynotchirag
Copy link
Contributor

@definitelynotchirag definitelynotchirag commented Oct 20, 2024 •
edited
Loading

  • Stop Sequence added into OpenAI params

@definitelynotchirag definitelynotchirag mentioned this pull request Oct 20, 2024
Open
HenryHengZJ
HenryHengZJ approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @definitelynotchirag !

@HenryHengZJ HenryHengZJ merged commit 35ce647 into FlowiseAI:main Oct 21, 2024
2 checks passed
@definitelynotchirag
Copy link
Contributor Author

@HenryHengZJ can you please add the hacktoberfest tag, so it can get accepted as a PR for hacktoberfest?

@HenryHengZJ
Copy link
Contributor

Is it too late now?

@definitelynotchirag
Copy link
Contributor Author

@HenryHengZJ no it isn't, thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryHengZJ HenryHengZJ HenryHengZJ approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@definitelynotchirag @HenryHengZJ