Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added S3_FORCE_PATH_STYLE environment variable support for AWS S3 client configuration to ensure compatibility with custom S3 endpoints and path-style URLs. This change sets the forcePathStyle option based on the environment variable, defaulting to false if not provided. #3315

Merged

Conversation

thiagolealassis
Copy link
Contributor

No description provided.

…ent configuration to ensure compatibility with custom S3 endpoints and path-style URLs. This change sets the forcePathStyle option based on the environment variable, defaulting to false if not provided.
@thiagolealassis
Copy link
Contributor Author

Summary of Changes

This PR introduces support for the S3_FORCE_PATH_STYLE environment variable to configure the forcePathStyle option in the AWS S3 client. The forcePathStyle option ensures that the S3 client uses path-style URLs when interacting with S3 endpoints, which is crucial when working with custom S3-compatible services or self-hosted endpoints.

Reason for the Change

In certain scenarios, particularly when using custom S3-compatible storage solutions or services with non-standard domain structures, the default virtual-hosted style for S3 bucket URLs may not be compatible. Enabling the forcePathStyle option allows the use of path-style URLs, improving compatibility in these environments.

By adding this environment variable, users gain flexibility in configuring the client without modifying the codebase directly, defaulting to false if the variable is not set.

Importance of Acceptance

This change is backward-compatible and does not affect users who do not require path-style URLs. However, it provides a critical feature for those integrating with custom S3 endpoints, ensuring broader compatibility and adaptability of the Flowise project in diverse deployment scenarios.

Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @thiagolealassis !

@HenryHengZJ HenryHengZJ merged commit 7868c8c into FlowiseAI:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants