Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/pdf loader add legacy option #322

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Bugfix/pdf loader add legacy option #322

merged 6 commits into from
Jun 16, 2023

Conversation

HenryHengZJ
Copy link
Contributor

No description provided.

@heresandyboy
Copy link

heresandyboy commented Jun 15, 2023

Hi Henry, could you also add the docker dependencies to the ./docker/Dockerfile too as part of this PR, the one that just npm installs flowise? With an update to the dockerhub image. Cheers.

@HenryHengZJ
Copy link
Contributor Author

HenryHengZJ commented Jun 15, 2023

hey @heresandyboy I've also updated the file in docker/Dockerfile, do you have additional things you want to add?

@heresandyboy
Copy link

heresandyboy commented Jun 15, 2023

hey @heresandyboy I've also updated the file in docker/Dockerfile, do you have additional things you want to add?

Nothing else I can think of for this one. Will you keep the toggle in for 'legacy' parser or make it default - if it is more capable than the other parser? Or perhaps use some error handling to try one, then the other.

@HenryHengZJ
Copy link
Contributor Author

so far I haven't seen much of the issue there, think will keep it as legacy toggle for now

HenryHengZJ and others added 3 commits June 16, 2023 13:41
# Conflicts:
#	packages/components/package.json
# Conflicts:
#	packages/components/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants