Enable inserting custom URL using basic auth #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryHengZJ
reviewed
Nov 21, 2023
| @@ -15,7 +15,7 @@ class ElasticSearchUserPassword implements INodeCredential { | |||
| 'Refer to <a target="_blank" href="https://www.elastic.co/guide/en/kibana/current/tutorial-secure-access-to-kibana.html">official guide</a> on how to get User Password from ElasticSearch' | |||
| this.inputs = [ | |||
| { | |||
| label: 'Cloud ID', | |||
| label: 'Cloud ID or custom server URL', | |||
| name: 'cloudId', | |||
There was a problem hiding this comment.
can we add a description to explain how to get Cloud ID OR what is custom server URL? Better if it has link to docs like here
HenryHengZJ
reviewed
Nov 21, 2023
| username: username, | ||
| password: password | ||
| if (cloudId.startsWith('http')) { | ||
| let username = getCredentialParam('username', credentialData, nodeData) |
There was a problem hiding this comment.
these 2 lines are redundant as its already declared above
|
Thanks for your suggestions. |
hemati
pushed a commit
to hemati/Flowise
that referenced
this pull request
Dec 27, 2023
…RLBasicAuth Enable inserting custom URL using basic auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the credential nodeId can be inserted a custom server URL and the basic auth will be used.