Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excel is not exporting the last row in 2.1.1 #85

Closed
deyaeddin opened this issue Dec 11, 2023 · 1 comment · Fixed by #86
Closed

Excel is not exporting the last row in 2.1.1 #85

deyaeddin opened this issue Dec 11, 2023 · 1 comment · Fixed by #86
Assignees
@flang

Comments

@deyaeddin
Copy link

deyaeddin commented Dec 11, 2023 •
edited
Loading

After upgrading to 2.1.1, the last row in Excel is ignored, I believe it's related to #82 because this is not the case for 2.1.0

Also, as @dominik42 mentioned, showing a progressBar would be a bonus.
@javier-godoy
Copy link
Member

Confirmed in https://addonsv24.flowingcode.com/gridexporter/basic

@flang flang self-assigned this Dec 11, 2023
flang added a commit that referenced this issue Dec 18, 2023
@flang
fix: include last row of grid in exported excel file
b575976 
Close #85
@flang flang mentioned this issue Dec 18, 2023
Merged
@paodb paodb closed this as completed in #86 Dec 21, 2023
paodb pushed a commit that referenced this issue Dec 21, 2023
@flang @paodb
fix: include last row of grid in exported excel file
b614f8d 
Close #85
mlopezFC pushed a commit that referenced this issue Feb 23, 2024
@flang @mlopezFC
fix: include last row of grid in exported excel file
3bc9a1c 
Close #85
paodb pushed a commit that referenced this issue Feb 23, 2024
@flang @paodb
fix: include last row of grid in exported excel file
945c490 
Close #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flang flang

Labels
None yet
Projects
Flowing Code Addons
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing last row when exporting Excel file FlowingCode/GridExporterAddon
3 participants
@flang @deyaeddin @javier-godoy