Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for conditional code #43

Closed
javier-godoy opened this issue Jul 13, 2023 · 0 comments
Closed

Add support for conditional code #43

javier-godoy opened this issue Jul 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@javier-godoy
Copy link
Member

javier-godoy commented Jul 13, 2023

Lines with a // hide-source comment are not rendered in the code snippet (#37).
Lines with a // show-source comment are rendered in the code snippet (#42).

What we need now is a way to display "nice" code depending on the framework version.

For instance:

// #if vaadin ge 22
// show-source foo();
// #elif vaadin eq 23
// show-source bar();
// #else
// show-source baz();
// #endif

would be rendered as foo(); in Vaadin 14-22, bar in Vaadin 23 and baz() in Vaadin 24.

@javier-godoy javier-godoy added the enhancement New feature or request label Jul 13, 2023
@javier-godoy javier-godoy self-assigned this Jul 13, 2023
javier-godoy added a commit that referenced this issue Jul 13, 2023
javier-godoy added a commit that referenced this issue Jul 14, 2023
javier-godoy added a commit that referenced this issue Jul 14, 2023
javier-godoy added a commit that referenced this issue Jul 17, 2023
javier-godoy added a commit that referenced this issue Jul 17, 2023
@paodb paodb closed this as completed in 0a4b971 Jul 17, 2023
@paodb paodb moved this to Done in Flowing Code Addons May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant