Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable PWA icon support #1366

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

gayanSandamal
Copy link
Contributor

@gayanSandamal gayanSandamal commented Oct 7, 2024

Description

Screenshot 2024-10-07 at 16 51 15 Screenshot 2024-10-07 at 16 58 23

Related Issue(s)

#1328

Notes

  • Icons doesn't need to come from the FlowFuse assets as this supports icons from any origin
  • Docs and built-in help are updated in a previous PR Added app icon field to ui base #1334
  • Need to restart the node-red server to apply the new icon

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gayanSandamal gayanSandamal linked an issue Oct 7, 2024 that may be closed by this pull request
@gayanSandamal gayanSandamal self-assigned this Oct 7, 2024
@gayanSandamal gayanSandamal changed the base branch from main to 1144-configurable-pwa-icon October 7, 2024 11:34
@joepavitt
Copy link
Collaborator

Screenshot 2024-10-07 at 15 50 45

This branch doesn't seem to contain the code in order to configure the icon?

@gayanSandamal
Copy link
Contributor Author

gayanSandamal commented Oct 7, 2024

Screenshot 2024-10-07 at 15 50 45 This branch doesn't seem to contain the code in order to configure the icon?

This is my bad. I forgot to get changes from the main branch (#1144-configurable-pwa-icon) related with this issue. Just updated.

This is ready for review

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Question, shouldnt the name come from the base node Name field?

image

As it stands, all of my dashboards are called "Node-RED Dashboard 2.0" - not a great UX IMHO.

This can of course be a follow up task.

@gayanSandamal
Copy link
Contributor Author

Looks good to me.

Question, shouldnt the name come from the base node Name field?

image

As it stands, all of my dashboards are called "Node-RED Dashboard 2.0" - not a great UX IMHO.

This can of course be a follow up task.

@Steve-Mcl As discussed a followup task has been raised #1375

@gayanSandamal gayanSandamal merged commit 5ed9c0d into 1144-configurable-pwa-icon Oct 10, 2024
2 checks passed
@gayanSandamal gayanSandamal deleted the 1328-Configurable-PWA-Icon branch October 10, 2024 08:53
@gayanSandamal gayanSandamal mentioned this pull request Oct 10, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable PWA Icon
3 participants