Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS to ensure there is a drop target for empty group #1270

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #1228

Description

Simple to fix, stupid hard to find!

Adds CSS to pseudo classes :empty and :empty::before to generate an "empty state" that is essentially a drop target

Demo

chrome_WUjSsXVCPm

Related Issue(s)

#1228

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@bartbutenaers
Copy link
Contributor

@Steve-Mcl,
How on earth did you find that one...
Nice catch, and really appreciated!!

@Steve-Mcl
Copy link
Contributor Author

Just noticed, the same issue exists for dropping groups onto a page.

#1228 (comment)

@joepavitt
Copy link
Collaborator

Just noticed, the same issue exists for dropping groups onto a page.

Will review this now, and we can hit that into a follow up

@joepavitt
Copy link
Collaborator

Cleaned up the CSS a little:

Screenshot 2024-09-11 at 11 14 19

nodes/config/ui_base.html Outdated Show resolved Hide resolved
@joepavitt joepavitt merged commit 8c18500 into main Sep 11, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 1228-permit-drop0into-empty-group branch September 11, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar - cannot drop widget on empty group
3 participants