Merge pull request #1146 from FlowFuse/fix-undefined-load

Fix: Ensure we check for existence of msg before using msg.payload
FlowFuse · Jul 30, 2024 · 19cca2b · 19cca2b
2 parents eef020d + dd2a9bd
commit 19cca2b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/ui/src/widgets/ui-button-group/UIButtonGroup.vue b/ui/src/widgets/ui-button-group/UIButtonGroup.vue
@@ -97,7 +97,7 @@ export default {
                 msg
             })
             // make sure we've got the relevant option selected on load of the page
-            if (msg.payload !== undefined) {
+            if (msg?.payload !== undefined) {
                 if (Array.isArray(msg.payload) && msg.payload.length === 0) {
                     this.selection = null
                 } else {

diff --git a/ui/src/widgets/ui-event/UIEvent.vue b/ui/src/widgets/ui-event/UIEvent.vue
@@ -37,7 +37,7 @@ export default {
     },
     created () {
         // can't do this in setup as we have custom onInput function
-        this.$dataTracker(this.id, null, this.onLoad)
+        this.$dataTracker(this.id)
         this.page = this.pages[this.$route.meta.id]
         this.pageview()
     },

diff --git a/ui/src/widgets/ui-text-input/UITextInput.vue b/ui/src/widgets/ui-text-input/UITextInput.vue
@@ -26,7 +26,7 @@
 import { mapState } from 'vuex' // eslint-disable-line import/order
 
 export default {
-    name: 'DBUIText',
+    name: 'DBUITextInput',
     inject: ['$socket', '$dataTracker'],
     props: {
         id: { type: String, required: true },
@@ -130,7 +130,7 @@ export default {
                 msg
             })
             // make sure we've got the relevant option selected on load of the page
-            if (msg.payload !== undefined) {
+            if (msg?.payload !== undefined) {
                 this.textValue = msg.payload
             }
         },