Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1151 Fix appium 'npm install' #1196

Merged
merged 8 commits into from
Dec 8, 2021
Merged

Conversation

sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Dec 8, 2021

This PR fixes dependencies conflict in appium's package.json

close #1151


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from tomholub December 8, 2021 13:12
@sosnovsky sosnovsky marked this pull request as ready for review December 8, 2021 13:12
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏 happy to see these updated

@tomholub tomholub merged commit d90c3e9 into master Dec 8, 2021
@tomholub tomholub deleted the bugfix/issue-1151-npm-install branch December 8, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'npm install' fails in appium folder
2 participants