Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sending email to users without valid keys should fail with appropriate modal #1138

Closed
tomholub opened this issue Dec 1, 2021 · 5 comments · Fixed by #1141
Closed

sending email to users without valid keys should fail with appropriate modal #1138

tomholub opened this issue Dec 1, 2021 · 5 comments · Fixed by #1141
Assignees
@fcvakintos
Labels
actionable
Milestone
0.6.0: Maintenanc...

Comments

@tomholub
Copy link
Collaborator

tomholub commented Dec 1, 2021

attempt to send email to accounts

  • expired at flowcrypt.com
  • revoked at flowcrypt.com

in both cases it should show an error modal - test for contents of that modal.

Both in one test called will not send email to recipients that only have revoked or expired keys
@tomholub tomholub added this to the ui tests milestone Dec 1, 2021
@fcvakintos
Copy link
Contributor

fcvakintos commented Dec 2, 2021 •
edited
Loading

@tomholub what are the accounts?
expired@flowcrypt.com?
revoked@flowcrypt.com?

@fcvakintos
Copy link
Contributor

is it a correct error for revoked account?
Screenshot 2021-12-02 at 12 39 58

@fcvakintos
Copy link
Contributor

the same error for expired account

@fcvakintos fcvakintos mentioned this issue Dec 2, 2021
Merged
5 tasks
@tomholub
Copy link
Collaborator Author

tomholub commented Dec 2, 2021 •
edited
Loading

Revoked looks good.

The expired one should look similar but should say expired in the modal. (checked the tests - looks good)

@fcvakintos
Copy link
Contributor

thanks

tomholub pushed a commit that referenced this issue Dec 2, 2021
@fcvakintos @acladima
issue #1138 added new scenarios for sending email to accounts with ex…
bd498cd 
…pired/revoked public key (#1141)

* added new scenarios for sending email for accounts with expired/revoked public key

* merged 2 scenarios into one, updated tests

Co-authored-by: Dmitry Sotnikov <dmytro.s@accel-labs.com>
@tomholub tomholub modified the milestones: ui tests, 0.6.0: Maintenance Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcvakintos fcvakintos

Labels
actionable
Projects
None yet
Milestone
0.6.0: Maintenance, preview, forward
2 participants
@tomholub @fcvakintos