Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor enhancements to query auto-completion #978

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Minor enhancements to query auto-completion #978

merged 3 commits into from
Jan 13, 2022

Conversation

JohnTheGr8
Copy link
Member

Quick one to address some minor annoyances:

  1. hitting Tab from a context menu seems to be only intended for accidents... I've ended up with "Set as topmost in this query" as my query text a few times 😂 I have disabled auto-completion in context menus since I don't see a use for it...
  2. hitting Tab from a ProcessKiller result would append the process number to the query, which would no longer work be a valid kill query
  3. hitting Tab from a PluginIndicator result would not append a space at the end

@JohnTheGr8 JohnTheGr8 added the enhancement New feature or request label Jan 13, 2022
@JohnTheGr8 JohnTheGr8 self-assigned this Jan 13, 2022
taooceros
taooceros previously approved these changes Jan 13, 2022
View reviewed changes
jjw24
jjw24 requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version bump for the two plugins please

@JohnTheGr8 JohnTheGr8 requested review from jjw24 and taooceros January 13, 2022 20:41
@JohnTheGr8 JohnTheGr8 added this to the 1.10.0 milestone Jan 13, 2022
@jjw24 jjw24 merged commit 10b8a35 into dev Jan 13, 2022
@jjw24 jjw24 deleted the use_autocomplete_text branch January 13, 2022 20:52
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 approved these changes

@Garulf Garulf Awaiting requested review from Garulf

@taooceros taooceros Awaiting requested review from taooceros

Assignees

@JohnTheGr8 JohnTheGr8

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnTheGr8 @jjw24 @taooceros