-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve context menu results #2529
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
build failed? |
47d3df6
to
3b8fc29
Compare
I think a test may have failed because i changed |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (8)actionkeywordassigned To accept these unrecognized words as correct, you could run the following commands... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/7810602507/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Forbidden patterns 🙅 (1)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: Reject duplicate words
Errors (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
We actually only need a shalow copy of the result. Do we get any library that can do that? https://learn.microsoft.com/en-us/dotnet/api/system.object.memberwiseclone?view=net-8.0 |
@Garulf want to get this into 1.18? I think it's pretty nice to have. |
Sounds good to me! |
Concern
Result
should be responsible for how it's deep copied and not the context menu method.Solution
Move all deep copy logic into
Result