Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve context menu results #2529

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Improve context menu results #2529

merged 3 commits into from
Mar 31, 2024

Conversation

Garulf
Copy link
Member

@Garulf Garulf commented Feb 4, 2024

Concern

Result should be responsible for how it's deep copied and not the context menu method.

Solution

Move all deep copy logic into Result

@Garulf Garulf added the enhancement New feature or request label Feb 4, 2024
@Garulf Garulf added this to the 1.17.1 milestone Feb 4, 2024
@Garulf Garulf self-assigned this Feb 4, 2024

This comment has been minimized.

This comment has been minimized.

@jjw24 jjw24 modified the milestones: 1.17.1, Future Feb 5, 2024
@VictoriousRaptor
Copy link
Contributor

build failed?

@VictoriousRaptor VictoriousRaptor force-pushed the improve-context-menu-results-2 branch from 47d3df6 to 3b8fc29 Compare February 7, 2024 06:02
@Garulf
Copy link
Member Author

Garulf commented Feb 7, 2024

I think a test may have failed because i changed Result

Copy link

github-actions bot commented Feb 7, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (8)

actionkeywordassigned
appropiate
Fody
hotkeys
mainwindow
Mvvm
Segoe
viewupdate

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the improve-context-menu-results-2 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/7810602507/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Reject duplicate words

\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s
Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 1
ℹ️ non-alpha-in-dictionary 10

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@taooceros
Copy link
Member

taooceros commented Feb 12, 2024

We actually only need a shalow copy of the result. Do we get any library that can do that?

https://learn.microsoft.com/en-us/dotnet/api/system.object.memberwiseclone?view=net-8.0

@taooceros
Copy link
Member

@Garulf want to get this into 1.18? I think it's pretty nice to have.

@Garulf
Copy link
Member Author

Garulf commented Mar 31, 2024

@Garulf want to get this into 1.18? I think it's pretty nice to have.

Sounds good to me!

@taooceros taooceros merged commit 4721b97 into dev Mar 31, 2024
4 checks passed
@taooceros taooceros deleted the improve-context-menu-results-2 branch March 31, 2024 16:49
@jjw24 jjw24 modified the milestones: Future, 1.18.0 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Refactor enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants