Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edge Workspace support #2378

Merged

Conversation

VictoriousRaptor
Copy link
Contributor

Fix #2158 #2375

Fixes exception when loading Edge bookmark file with workspace feature enabled.

Tested:

  • No errors when starting Flow, when Bookmark plugin and Edge's workspace enabled.
  • Bookmarks in workspace can be indexed.

@VictoriousRaptor VictoriousRaptor added the bug Something isn't working label Oct 3, 2023
@VictoriousRaptor VictoriousRaptor added this to the 1.17.0 milestone Oct 3, 2023
@VictoriousRaptor VictoriousRaptor self-assigned this Oct 3, 2023
@VictoriousRaptor VictoriousRaptor linked an issue Oct 3, 2023 that may be closed by this pull request
2 tasks
@jjw24
Copy link
Member

jjw24 commented Oct 3, 2023

Why is the spell check action failing

@VictoriousRaptor
Copy link
Contributor Author

Why is the spell check action failing

IDK, no idea. I did some test in my repo and seems like it can't checkout cross-repo PRs.

@VictoriousRaptor VictoriousRaptor merged commit 08cc8b5 into Flow-Launcher:dev Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Browsers Bookmark Plugin BUG: Edge New Feature Workspaces Crash Browser Bookmarks
2 participants