Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Setting Panel Layout (System & JsonRPC) #1613

Merged
merged 8 commits into from
Dec 12, 2022
Merged

Adjust Setting Panel Layout (System & JsonRPC) #1613

merged 8 commits into from
Dec 12, 2022

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Dec 9, 2022 •
edited
Loading

What's the PR

  • Adjust Setting Panel Margin & Column Width to responsive (System plugin)
  • Adjust JsonRPC Panel Layout
  • Added layout for input box with browse button / hyperlink (function not implement, This part will be implemented later.)

TestCases

  • The left margin must be positioned to align with the top item.
  • The settings panel for plugins using jsorpc should be displayed appropriately.
  • Panel item's color should change when changed setting window theme

image

@onesounds
- Adjust JsonRPCplugin Panel Layout
101955f 
- Adjust System Plugin Setting Panel Margin
@onesounds
- Adjust JsonRPCplugin Panel Layout
b1768b5 
- Adjust System Plugin Setting Panel Margin
@onesounds
Fix Conflict
92c068d
@onesounds onesounds marked this pull request as draft December 9, 2022 09:28
@onesounds onesounds self-assigned this Dec 11, 2022
@onesounds onesounds marked this pull request as ready for review December 11, 2022 03:49
@jjw24 jjw24 enabled auto-merge December 12, 2022 09:02
@jjw24 jjw24 added the bug Something isn't working label Dec 12, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Dec 12, 2022
@jjw24 jjw24 merged commit 50b5a0e into Flow-Launcher:dev Dec 12, 2022
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@onesounds onesounds

Labels
bug Something isn't working
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@onesounds @jjw24