Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UWP class in Program plugin #1581

Merged
merged 26 commits into from
Nov 30, 2022
Merged

Refactor UWP class in Program plugin #1581

merged 26 commits into from
Nov 30, 2022

Conversation

VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Nov 28, 2022 •
edited
Loading

Changes

  • Refator UWP and UWP.Application.
  • Use WinRT API and mannually parse appmanifest.xml to get info of UWP Apps to avoid interops. (Thanks to PT Run and Wox)
  • Use ImageLoader to load icons.
  • Remove ApplicationActivationHelper interop.\
  • Remove UWP icon background color.

Tests

  • Apps should be correctly indexed.
  • Apps should be launched either elevated or unelevated correctly, base on user choice and CanRunElevated specified in manifest.
  • Icons should be shown correctly.
  • logging for exceptions while indexing apps.
  • Index performance is generally unaffected.
  • Different apps in the same package (like email and calendar) shows different if icons.

Todos

  • Preview images (still require changes in Preview pr)
  • Clear unused code.

@VictoriousRaptor VictoriousRaptor self-assigned this Nov 28, 2022
@VictoriousRaptor VictoriousRaptor changed the title Use winRT api for uwp info and logo Refactor UWP clas in Program plugin Nov 28, 2022
@VictoriousRaptor VictoriousRaptor marked this pull request as ready for review November 28, 2022 16:13
@VictoriousRaptor VictoriousRaptor changed the title Refactor UWP clas in Program plugin Refactor UWP class in Program plugin Nov 28, 2022
jjw24
jjw24 reviewed Nov 30, 2022
View reviewed changes
Plugins/Flow.Launcher.Plugin.Program/Programs/UWP.cs
}

#region logo legacy
// preserve for potential future use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what can we use this for in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part fills the background of the icon with background color in appmanifest.Technically background + color is the full icon that app developer want to show. onesounds removed it in preview pr. I move it here to avoid conflict. Still I feel like maybe we may need to look into it later so I just commented it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good

@jjw24 jjw24 added the enhancement New feature or request label Nov 30, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 30, 2022
@jjw24 jjw24 enabled auto-merge November 30, 2022 08:56
@jjw24 jjw24 added bug Something isn't working and removed enhancement New feature or request labels Nov 30, 2022
@jjw24 jjw24 merged commit b0297d3 into Flow-Launcher:dev Nov 30, 2022
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
@VictoriousRaptor VictoriousRaptor deleted the RefactorUWP branch December 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@VictoriousRaptor VictoriousRaptor

Labels
bug Something isn't working Code Refactor
Projects
Work In Progress
Archived in project
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@VictoriousRaptor @jjw24