-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks with Plugin store layout #1510
Conversation
- Fix No Result in plugin store - Adjust Store Item Focus Visual
@taooceros 'refresh' button wrong work after merged Label PR , It seems like a simple task, but I couldn't fix it. Please add it on this pr or work on it separately. (Don't forget it!) |
@onesounds Are the test cases completed? |
in my case, Yes. but not sure. simply you can test (like when you did in smooth scroll pr) memory leak issue and working plugin store buttons. if its all fine, it is mergable. |
With dev branch, I can consistently push the memory usage up to 330mb on average by going to Settings -> Plugin Store scroll up and down a couple times -> exit and then repeat. Doing the same with this PR I see memory usage is around 250mb on average and only hits as high as 280mb rarely for a second but then quickly drops back down to the 250mb average. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing plugins via mouse click is not working. Click on the install button then use mouse to click the install plugin result, nothing happens. Using enter works.
ok. I'll check. when fix done, I'll mention you again. thanks. |
…r other tab. Close Flyout when clicking install
…ll and update button
What's the PR
Test Cases