[Program Plugin] Support .url file #1476

LeLocTai · 2022-10-16T09:27:25Z

Notably Steam use .url for games shortcut.

What's the PR

Add Function the program plug-in to search for shortcut that use the .url format, such as Steam or Epic.
Changed Label File Suffixes -> File Type
Changed File Type Window.
User can set up protocols other than Steam and Epic.
Default Setting
- on : exe, lnk, ms-app / steam, epic

Test Cases

The icon in the url file should be displayed normally.
The default settings for the first installation should be as follows: on : exe, lnk, ms-app / steam, epic
It must behave according to the checkboxes.
The file format / protocol entered in the custom entry must work.
Even if a custom item is entered, it should not work if you uncheck the check box.
Items entered in custom items must be saved even if they are not used.
The custom text box should only be visible when you turn on the custom
When you focus on each textbox, the appropriate description should be displayed.
There should be no conflicts with users who have existing settings.

VictoriousRaptor · 2022-10-16T10:53:59Z

What if the .url file is not a steam shortcut but a internet page? Obviously we don't want it in Program.

LeLocTai · 2022-10-16T11:06:07Z

It is possible to filter by protocol. But to be honest I've been adding url to Program for months without this patch and never have a thought about it. My brain just filter them out.
I hope we can merge this as is, and maybe adding a customizable protocol later. There are already many useless results anyway, and fuzzy match have always do a good job of surfacing the relevant one quickly. Having thumbnail on steam shortcut is great and eliminate the need for extra plugin. Those who want less result can always remove .url from Program settings.

onesounds · 2022-10-17T05:03:47Z

The above screen shot is not this pr, but only preview pr and suffix are set.

Currently, we are going to change the icon part in other PR (preview). If this pr is applied, the url file type icon will also be displayed appropriately.
How about adding only .url to the suffix default setting for this feature? When I test it, it seems to work the same way as this PR. This pr is focused on outputting the icon. If the preview(and icon) pr works properly, this function can be solved with suffix alone.

https://developer.valvesoftware.com/wiki/Steam_browser_protocol

It's my first time seeing this url file type, and I confirmed that usually use it on Steam. The other files were link files to websites that most would not use. (docs in web or Game services that require website login) Considering the high number of downloads of the Steam plug-in, it is certainly inconvenient that the Steam game cannot be searched in windows. Although the number of downloads of the Steam Plug-in will decrease, it seems to good to be provided as a default. (There may be overlapping results with existing Steam Plug-in users.)

VictoriousRaptor · 2022-10-17T05:15:47Z

Personally I don't think this is a good idea. Not the idea of supporting indexing steam games itself, but the way you manage these.url files. You need to put these .url files in a folder and manually manage them. Steam only let you add shortcuts to desktop iirc. If you don't want all these shortcuts on your desktop you need to cut them to somewhere else.

LeLocTai · 2022-10-17T05:22:03Z

Stream also create url files in the start menu. You don't have to manually do anything. Even windows builtin search can find these files, and this pr bring Flow to parity with it which is the bare minimum in term of capabilities.

My main issue with the steam plugin is it doesn't score the results, so you must use a trigger word which is very inconvenient.

VictoriousRaptor · 2022-10-17T05:43:11Z

Stream also create url files in the start menu. You don't have to manually do anything

It's my problem then. I just found that I never check the "Add to start menu" checkbox.

My main issue with the steam plugin is it doesn't score the results, so you must use a trigger word which is very inconvenient.

Seems related to Garulf/Steam-Search#30.

LeLocTai · 2022-10-17T06:09:46Z

I'm aware of the issue and have discussed with Garulf about it. While it is simple to give the results a score boost, it is not easy to give them a score that play well with other result since fuzzy match is not accessible in python. Scoring is also not well documented in general.

Garulf · 2022-10-17T18:38:14Z

I'm aware of the issue and have discussed with Garulf about it. While it is simple to give the results a score boost, it is not easy to give them a score that play well with other result since fuzzy match is not accessible in python. Scoring is also not well documented in general.

I have a PR in the works that'll allow Python plugins to use Flow Launchers Fuzzy matching.

taooceros · 2022-10-17T20:05:31Z

I'm aware of the issue and have discussed with Garulf about it. While it is simple to give the results a score boost, it is not easy to give them a score that play well with other result since fuzzy match is not accessible in python. Scoring is also not well documented in general.

I have a PR in the works that'll allow Python plugins to use Flow Launchers Fuzzy matching.

really??? how's that possible🤔

Garulf · 2022-10-19T01:25:07Z

really??? how's that possible🤔

Actually not hard to implement. I just haven't decided on the design.

- Add Auto Hide Styles

onesounds · 2022-10-24T01:18:16Z

@VictoriousRaptor Error.

taooceros

LGTM, but there's a few things to check.

taooceros · 2022-10-30T16:44:52Z

Flow.Launcher/ViewModel/ResultViewModel.cs

            if (ImageLoader.CacheContainImage(imagePath))
            {
                // will get here either when icoPath has value\icon delegate is null\when had exception in delegate
-                image = ImageLoader.Load(imagePath);
+                image = ImageLoader.Load(imagePath, loadFullImage);


The loadFullImage will not do anything actually. We may want to change how cache work later. pending to be do in #1351.

taooceros · 2022-10-30T16:50:47Z

Plugins/Flow.Launcher.Plugin.Program/Programs/Win32.cs

+                }
+
+                var iconPath = urlSection?["IconFile"];
+                if (iconPath != null && Path.GetExtension(iconPath).Equals(".ico", StringComparison.OrdinalIgnoreCase))


Why do we need to check the extension? What may be the extension? jpg or png? Though those two are both supported I believe?

taooceros · 2022-10-30T16:59:52Z

Plugins/Flow.Launcher.Plugin.Program/Settings.cs

+
+        [JsonIgnore]
+        public Dictionary<string, bool> BuiltinProtocolsStatus { get; set; } = new Dictionary<string, bool>{
+            { $"steam://run/{SuffixSeparator}steam://rungameid/", true }, { "com.epicgames.launcher://apps/", true }, { $"http://{SuffixSeparator}https://", false}


I somehow feel that we don't use the functionality of Dictionary. Consider using List<(string,bool)> instead? Thoug this is fine.

Plugins/Flow.Launcher.Plugin.Program/ProgramSuffixes.xaml

jjw24

Thanks for doing the testing 👍

Fix #1476

Support .url file

750cfa4

onesounds assigned LeLocTai Oct 18, 2022

onesounds and others added 9 commits October 22, 2022 15:39

Adjust Text / Change Button / Add Layout

b559ad1

- Adjust Strings

c27761e

- Add Auto Hide Styles

Adjust Strings and add guide text

24ad8ed

Adjust margin

d5be961

Data binding for suffixes

d13c381

Fix suffixes

b77a8f7

protocols setting

1715f81

Update text

5103b2b

bugfix

642ea4a

VictoriousRaptor added the enhancement New feature or request label Oct 23, 2022

Adjust text

6f46504

VictoriousRaptor requested a review from jjw24 October 23, 2022 17:35

onesounds assigned VictoriousRaptor Oct 24, 2022

VictoriousRaptor added 3 commits October 24, 2022 14:00

bugfix

2ba1559

Check null

568dced

Check if url field is null

c8dfd56

VictoriousRaptor enabled auto-merge October 24, 2022 17:18

VictoriousRaptor disabled auto-merge October 24, 2022 17:18

VictoriousRaptor enabled auto-merge October 24, 2022 17:19

Merge branch 'dev' into dev

af7539a

taooceros reviewed Oct 30, 2022

View reviewed changes

VictoriousRaptor added 2 commits October 31, 2022 01:52

Fix IcoPath for epic urls

c194d21

fix typo

902c88d

jjw24 added the review in progress Indicates that a review is in progress for this PR label Oct 31, 2022

VictoriousRaptor added 2 commits November 1, 2022 18:54

Merge branch 'dev' into dev

d1bb08a

Save settings

cc65562

jjw24 reviewed Nov 1, 2022

View reviewed changes

Plugins/Flow.Launcher.Plugin.Program/ProgramSuffixes.xaml Outdated Show resolved Hide resolved

formatting

81555ec

jjw24 approved these changes Nov 1, 2022

View reviewed changes

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 1, 2022

jjw24 added this to the 1.10.0 milestone Nov 1, 2022

VictoriousRaptor merged commit e17ec6a into Flow-Launcher:dev Nov 1, 2022

VictoriousRaptor mentioned this pull request Nov 2, 2022

[Dev] Fix #1476 #1508

Merged

VictoriousRaptor added a commit that referenced this pull request Nov 2, 2022

Merge pull request #1508 from VictoriousRaptor/Fix-1476

4232ef7

Fix #1476

VictoriousRaptor mentioned this pull request Nov 8, 2022

[Program Plugin] Search programs in PATH #1479

Merged

2 tasks

jjw24 mentioned this pull request Dec 12, 2022

Release 1.10.0 | Plugin 3.0.0 #957

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Program Plugin] Support .url file #1476

[Program Plugin] Support .url file #1476

LeLocTai commented Oct 16, 2022 •

edited by onesounds

Loading

VictoriousRaptor commented Oct 16, 2022

LeLocTai commented Oct 16, 2022

onesounds commented Oct 17, 2022 •

edited

Loading

VictoriousRaptor commented Oct 17, 2022

LeLocTai commented Oct 17, 2022

VictoriousRaptor commented Oct 17, 2022

LeLocTai commented Oct 17, 2022

Garulf commented Oct 17, 2022

taooceros commented Oct 17, 2022

Garulf commented Oct 19, 2022

onesounds commented Oct 24, 2022

taooceros left a comment

taooceros Oct 30, 2022

taooceros Oct 30, 2022

taooceros Oct 30, 2022

jjw24 left a comment

[Program Plugin] Support .url file #1476

[Program Plugin] Support .url file #1476

Conversation

LeLocTai commented Oct 16, 2022 • edited by onesounds Loading

VictoriousRaptor commented Oct 16, 2022

LeLocTai commented Oct 16, 2022

onesounds commented Oct 17, 2022 • edited Loading

VictoriousRaptor commented Oct 17, 2022

LeLocTai commented Oct 17, 2022

VictoriousRaptor commented Oct 17, 2022

LeLocTai commented Oct 17, 2022

Garulf commented Oct 17, 2022

taooceros commented Oct 17, 2022

Garulf commented Oct 19, 2022

onesounds commented Oct 24, 2022

taooceros left a comment

Choose a reason for hiding this comment

taooceros Oct 30, 2022

Choose a reason for hiding this comment

taooceros Oct 30, 2022

Choose a reason for hiding this comment

taooceros Oct 30, 2022

Choose a reason for hiding this comment

jjw24 left a comment

Choose a reason for hiding this comment

LeLocTai commented Oct 16, 2022 •

edited by onesounds

Loading

onesounds commented Oct 17, 2022 •

edited

Loading