Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Clear Log' Button #1418

Merged
merged 8 commits into from
Oct 5, 2022
Merged

Add 'Clear Log' Button #1418

merged 8 commits into from
Oct 5, 2022

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds added the enhancement New feature or request label Sep 27, 2022
@onesounds onesounds self-assigned this Sep 27, 2022
@onesounds onesounds changed the title Add 'Clear Log' Button in about Add 'Clear Log' Button Sep 27, 2022
@onesounds
Copy link
Contributor Author

image

  • Directory size in label

Comment on lines 562 to 568
DirectoryInfo dirInfo = new DirectoryInfo(Path.Combine(DataLocation.DataDirectory(), Constant.Logs, Constant.Version));
long size = 0;
foreach (FileInfo fi in dirInfo.GetFiles("*", SearchOption.AllDirectories))
{
size += fi.Length;
}
return string.Format(_translater.GetTranslation("clearlogfolder")) + " (" + FormatBytes(size) + ")" ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/a/22111211

Try this instead? (it looks more elegant XD)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/a/22111211

Try this instead? (it looks more elegant XD)

Not easy for me. 😂 Do as u wish, please.

Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjw24 jjw24 enabled auto-merge October 5, 2022 10:13
@jjw24 jjw24 added this to the 1.10.0 milestone Oct 5, 2022
@jjw24 jjw24 merged commit b87ee20 into Flow-Launcher:dev Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants