Shortcuts to adjust width size, number of results shown and game mode #1369

onesounds · 2022-09-07T05:18:29Z

Quick Adjust Width Size by Ctrl + Plus/Minus in query box.
Quick Adjust Max Result Shown by Ctrl + [ , Ctrl + ] in query box.
Add Tooltip
Adjustment adhere to maximum and minimum allowed
Ctrl + F12 to change to Game Mode

onesounds · 2022-09-08T07:48:53Z

Add Ctrl+F12 to Toggle Game Mode.

onesounds · 2022-09-08T09:11:00Z

I changed it because it was more intuitive to change it like this.

Plus Minus : Max Result
square brackets : Width

taooceros · 2022-09-10T14:55:50Z

Flow.Launcher/MainWindow.xaml.cs

+                    if (specialKeyState.CtrlPressed)
+                    {
+
+                        _settings.WindowSize = _settings.WindowSize + 100;


I am curious why does this work. I suspect we need to set the property in the viewmodel to trigger change?

…generate RelayCommand)

taooceros · 2022-09-19T20:33:11Z

@onesounds please take a look on my latest change

onesounds · 2022-09-20T01:31:17Z

@onesounds please take a look on my latest change

It's well organized and the code works well.

onesounds · 2022-09-21T08:30:07Z

but why the build faild?

Garulf · 2022-09-21T22:04:00Z

Are we still using Ctrl+ Arrow keys?
If so this may interfere with normal text box shortcuts.

taooceros · 2022-09-21T22:05:05Z

Are we still using Ctrl+ Arrow keys?
If so this may interfere with normal text box shortcuts.

I remove them.

jjw24 · 2022-10-10T02:11:36Z

When you use the shortcut for expanding or shrinking the query window width, the new width doesn't seem to get reflected back in the settings window.
Expanding the width of the query window using the shortcut does not respect the maximum width in the Settings, consequently you can keep expanding the width forever
Using the shortcut to expand the result list doesn't respect the maximum allowed results displayed, consequently can keep expanding forever.

- Size reflect to Slider

onesounds · 2022-10-10T06:38:44Z

When you use the shortcut for expanding or shrinking the query window width, the new width doesn't seem to get reflected back in the settings window.

Expanding the width of the query window using the shortcut does not respect the maximum width in the Settings, consequently you can keep expanding the width forever

Using the shortcut to expand the result list doesn't respect the maximum allowed results displayed, consequently can keep expanding forever.

Fixed

onesounds · 2022-10-10T06:43:48Z

Need to make sure the subtitle sentence is appropriate. @Garulf

…auncher into QuickSizeAdjust

jjw24 · 2022-10-14T10:22:14Z

Flow.Launcher/ViewModel/MainViewModel.cs


 namespace Flow.Launcher.ViewModel
 {
-    public class MainViewModel : BaseModel, ISavable
+    public partial class MainViewModel : BaseModel, ISavable


@taooceros why is this changed to partial class?

Because I would like to use the mvvm toolkit to simplify the code of creating RelayCommand, which requires partial to generate additional code.

jjw24 · 2022-10-14T10:24:09Z

global.json

-        "version": "6.0.100",
-        "rollForward": "latestFeature"
+        "version": "6.0.*",
+        "rollForward": "latestPatch"


@taooceros what's this change for?

Oh it shouldn't be there (I am testing different version of dotnet and see which one can help with the bug. However it is not needed because workaround is found)...Though it makes sense to apply the latest patch since that generally includes some security fixes.

jjw24 · 2022-10-14T10:26:36Z

Flow.Launcher/Flow.Launcher.csproj

+
+  <Target Name="RemoveDuplicateAnalyzers" BeforeTargets="CoreCompile">
+    <!-- Work around https://github.com/dotnet/wpf/issues/6792 -->
+
+    <ItemGroup>
+      <FilteredAnalyzer Include="@(Analyzer->Distinct())" />
+      <Analyzer Remove="@(Analyzer)" />
+      <Analyzer Include="@(FilteredAnalyzer)" />
+    </ItemGroup>
+  </Target>


@taooceros What's this change for us specifically?

jjw24 · 2022-10-14T10:27:39Z

Need to make sure the subtitle sentence is appropriate. @Garulf

Updated the wording, hopefully ok.

taooceros · 2022-10-14T23:01:08Z

@taooceros What's this change for us specifically?

I couldn't reply directly. This is a workaround for source generator. Details here dotnet/wpf#6792.

If that's being fixed, we can remove it.

taooceros · 2022-10-14T23:02:45Z

@taooceros What's this change for us specifically?

I couldn't reply directly. This is a workaround for source generator. Details here dotnet/wpf#6792.

If that's being fixed, we can remove it.

I think it is fixed (in 6.0.400+). However it seems that appveyor hasn't got the latest image. Let's wait a while later.

VictoriousRaptor · 2022-10-17T08:34:56Z

Technically it's Ctrl + "=" and Ctrl + "-".

jjw24 · 2022-10-17T20:24:41Z

👍 #1480

onesounds · 2022-10-18T01:48:56Z

@jjw24 @VictoriousRaptor

You guys are too programmers. Why don't you consider the average user?
This is my intended to make it easier for the general user to memorize hotkey.
I changed the shortcut once in the middle for this PR.

+:increase count.
-: decrease count.
[ : decrease size
] : increase size

It is a key chosen so that it can be intuitively understood.

"Technically it's Ctrl + "=" and Ctrl + "-"." <- This can be talked about. This is because it is not a strong suggestion.
"OK I changed it" <- NOoooooooo

Photoshop.
They are not idiots who don't even know the keycode.

memopad

firefox

I have never seen a case of writing = and - instead of + and - when matching these shortcuts. What stupid program writes shortcuts like this? flow launcher? 😂

jjw24 · 2022-10-18T02:11:59Z

Lol looking at those screenshots, realised I never paid much attention to how those shortcuts are described, makes sense. Let's revert it back.

VictoriousRaptor · 2022-10-18T02:16:58Z

In fact I found it when was looking at my keyboard and realized that + needs a shift combined to input. And I opened powertoys,tried adding some hotykeys, found that they use "=" to describe that key. And I thought every software use "=". Really never paid attention to that.

onesounds · 2022-10-18T02:26:22Z

good. You guys sins are forgiven.

VictoriousRaptor · 2022-10-18T02:27:27Z

So maybe for a single key, = is correct but for pairs like our new shortcut, + and - is a more user friendly choice.

- Quick Adjust Width Size by Ctrl + Plus/Minus

91c9397

onesounds added the kind/ui related to UI, icons, themes, etc label Sep 7, 2022

onesounds self-assigned this Sep 7, 2022

onesounds added 2 commits September 7, 2022 14:45

- Add Quick adjust maxresultcount by CTRL+[ and ]

2ca2fe9

- Add Ctrl+F12 to Toggle Game mode

16400ab

Change Shortcut each other (+-,[])

9cfb92b

taooceros reviewed Sep 10, 2022

View reviewed changes

onesounds and others added 2 commits September 14, 2022 11:01

Adjust Keys assign

e67e4fd

Use Command in ViewModel to control data change (Add MVVM Toolkit to …

01c9be3

…generate RelayCommand)

Merge branch 'dev' into QuickSizeAdjust & Work around dotnet/wpf#6792

0baf04e

taooceros force-pushed the QuickSizeAdjust branch from b1626a7 to 0baf04e Compare September 27, 2022 16:48

onesounds added 2 commits October 3, 2022 16:22

Merge branch 'dev' into QuickSizeAdjust

c7754e9

Merge branch 'dev' into QuickSizeAdjust

753e261

jjw24 added review in progress Indicates that a review is in progress for this PR enhancement New feature or request labels Oct 5, 2022

jjw24 added this to the 1.10.0 milestone Oct 5, 2022

onesounds added 2 commits October 10, 2022 15:33

- Add MaxWidth Limit

644c560

- Size reflect to Slider

Fix MaxResultCount

83262de

Merge branch 'dev' into QuickSizeAdjust

7839f0a

Merge branch 'dev' into QuickSizeAdjust

5164c18

onesounds added 2 commits October 13, 2022 13:57

Fix Max/Min Logic

833857d

Merge branch 'QuickSizeAdjust' of https://github.com/onesounds/Flow.L…

5236279

…auncher into QuickSizeAdjust

jjw24 changed the title ~~Quick Adjust Width Size by Ctrl + Plus/Minus~~ Quick shortcut to adjust width size and number of results shown Oct 14, 2022

jjw24 added 2 commits October 14, 2022 20:46

fix minimum results to show

eef6878

update wording

6592de9

jjw24 changed the title ~~Quick shortcut to adjust width size and number of results shown~~ Shortcuts to adjust width size, number of results shown and game mode Oct 14, 2022

jjw24 reviewed Oct 14, 2022

View reviewed changes

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Oct 17, 2022

jjw24 approved these changes Oct 17, 2022

View reviewed changes

jjw24 merged commit 35a5aec into Flow-Launcher:dev Oct 17, 2022

jjw24 mentioned this pull request Dec 12, 2022

Release 1.10.0 | Plugin 3.0.0 #957

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shortcuts to adjust width size, number of results shown and game mode #1369

Shortcuts to adjust width size, number of results shown and game mode #1369

onesounds commented Sep 7, 2022 •

edited by jjw24

Loading

onesounds commented Sep 8, 2022

onesounds commented Sep 8, 2022

taooceros Sep 10, 2022

taooceros commented Sep 19, 2022

onesounds commented Sep 20, 2022

onesounds commented Sep 21, 2022

Garulf commented Sep 21, 2022 •

edited

Loading

taooceros commented Sep 21, 2022

jjw24 commented Oct 10, 2022 •

edited

Loading

onesounds commented Oct 10, 2022

onesounds commented Oct 10, 2022

jjw24 Oct 14, 2022

taooceros Oct 14, 2022

jjw24 Oct 14, 2022

taooceros Oct 14, 2022

jjw24 Oct 14, 2022

jjw24 commented Oct 14, 2022

taooceros commented Oct 14, 2022

taooceros commented Oct 14, 2022 •

edited

Loading

VictoriousRaptor commented Oct 17, 2022

jjw24 commented Oct 17, 2022

onesounds commented Oct 18, 2022

jjw24 commented Oct 18, 2022 •

edited

Loading

VictoriousRaptor commented Oct 18, 2022

onesounds commented Oct 18, 2022

VictoriousRaptor commented Oct 18, 2022

Shortcuts to adjust width size, number of results shown and game mode #1369

Shortcuts to adjust width size, number of results shown and game mode #1369

Conversation

onesounds commented Sep 7, 2022 • edited by jjw24 Loading

onesounds commented Sep 8, 2022

onesounds commented Sep 8, 2022

taooceros Sep 10, 2022

Choose a reason for hiding this comment

taooceros commented Sep 19, 2022

onesounds commented Sep 20, 2022

onesounds commented Sep 21, 2022

Garulf commented Sep 21, 2022 • edited Loading

taooceros commented Sep 21, 2022

jjw24 commented Oct 10, 2022 • edited Loading

onesounds commented Oct 10, 2022

onesounds commented Oct 10, 2022

jjw24 Oct 14, 2022

Choose a reason for hiding this comment

taooceros Oct 14, 2022

Choose a reason for hiding this comment

jjw24 Oct 14, 2022

Choose a reason for hiding this comment

taooceros Oct 14, 2022

Choose a reason for hiding this comment

jjw24 Oct 14, 2022

Choose a reason for hiding this comment

jjw24 commented Oct 14, 2022

taooceros commented Oct 14, 2022

taooceros commented Oct 14, 2022 • edited Loading

VictoriousRaptor commented Oct 17, 2022

jjw24 commented Oct 17, 2022

onesounds commented Oct 18, 2022

jjw24 commented Oct 18, 2022 • edited Loading

VictoriousRaptor commented Oct 18, 2022

onesounds commented Oct 18, 2022

VictoriousRaptor commented Oct 18, 2022

onesounds commented Sep 7, 2022 •

edited by jjw24

Loading

Garulf commented Sep 21, 2022 •

edited

Loading

jjw24 commented Oct 10, 2022 •

edited

Loading

taooceros commented Oct 14, 2022 •

edited

Loading

jjw24 commented Oct 18, 2022 •

edited

Loading