-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent Dispatch Queue #97
Merged
TesteurManiak
merged 8 commits into
Floating-Dartists:dev
from
EPNW:persistent_dispatch_queue
May 31, 2023
Merged
Persistent Dispatch Queue #97
TesteurManiak
merged 8 commits into
Floating-Dartists:dev
from
EPNW:persistent_dispatch_queue
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TesteurManiak
requested changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, a big thank you for your contribution. I just have some small remarks on the code.
MeixDev
added
documentation
Improvements or additions to documentation
and removed
documentation
Improvements or additions to documentation
labels
May 31, 2023
EPNW-Eric
force-pushed
the
persistent_dispatch_queue
branch
from
May 31, 2023 11:05
34287d4
to
6ead7db
Compare
TesteurManiak
approved these changes
May 31, 2023
EPNW-Eric
force-pushed
the
persistent_dispatch_queue
branch
from
May 31, 2023 15:37
18e9200
to
da580ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the app is terminated and there are still undispatched actions, they will be lost.
To circumvent this, I added an implementation that allows the dispatch queue to be persistent and store actions in the
LocalStorage
until they are dispatched.I also added a filter mechanism that allows the user to select which actions are still entitled to dispatching after the next app launch. The default filter only retains actions that are not older than a day, since older actions would need a
tokenAuth
(see Tracking HTTP API sectioncdt
).