Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping implementation #79

Merged
merged 1 commit into from
May 14, 2023
Merged

Ping implementation #79

merged 1 commit into from
May 14, 2023

Conversation

EPNW-Eric
Copy link
Contributor

This PR implements the ping logic (#78), it is based on the dequeue logic.

I also changed the type of the dequeueInterval parameter to Duration from int, which is imo a bit clearer.

@TesteurManiak
Copy link
Member

Thanks (again) for the contribution! 😀
I'll try to take a look at it as soon as I can.

TesteurManiak
TesteurManiak approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TesteurManiak TesteurManiak merged commit 588ec55 into Floating-Dartists:dev May 14, 2023
@EPNW-Eric EPNW-Eric deleted the ping branch May 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TesteurManiak TesteurManiak TesteurManiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EPNW-Eric @TesteurManiak