Implemented campaigns and tests in style of EventInfo tests #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added an utility method which simplifies a bit error checking this might help reduce the boilerplate in |
|
I will incorporate that 👍 |
EPNW-Eric
force-pushed
the
campaigns_rebase
branch
from
c3a31fc to
f9d3dbd
Compare
TesteurManiak
approved these changes
May 10, 2023
TesteurManiak
deleted the branch
Floating-Dartists:refactor/#65_update-parameters
|
Oops sorry @EPNW-Eric, seems like your PRs targeting |
|
Will do so 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to distinguish between app entries by clicking on a notification and normal launches. After reading a bit more about the different tracking techniques we figured that we should model these entires using acquisition channels. Therefor, we need campaigns.
The idea was now to add an optional campaign parameter to
trackScreenWithNamecalls and theTraceableClientMixin.This time, I tried to provide some tests and took the tests for
EventInfoas orientation, since the newCampaignclass is also just a data object for most parts.