Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return bytesWritten instead of True on successfull file.write() #88

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

Flipez
Copy link
Owner

@Flipez Flipez commented Jun 26, 2022

This fixes #37

Signed-off-by: Flipez code@brauser.io

@vercel
Copy link

vercel bot commented Jun 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rocket-lang ✅ Ready (Inspect) Visit Preview Jun 26, 2022 at 6:22PM (UTC)

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #88 (c1db6e2) into main (6adb5f9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files          90       90           
  Lines        2916     2916           
=======================================
  Hits         2496     2496           
  Misses        357      357           
  Partials       63       63           
Impacted Files Coverage Δ
object/file.go 47.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adb5f9...c1db6e2. Read the comment docs.

@Flipez Flipez merged commit 6461ba9 into main Jun 26, 2022
@Flipez Flipez deleted the improve-file-write branch June 26, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve file.write()
1 participant