Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

states lost in version 2.2.2 #48

Closed
zengxiaolei opened this issue Jan 12, 2020 · 5 comments
Closed

states lost in version 2.2.2 #48

zengxiaolei opened this issue Jan 12, 2020 · 5 comments

Comments

@zengxiaolei
Copy link

Firstly, It's nice to see a new version of flexbe_app and flexbe_behavior_engine :-)
I checkout flexbe_behavior_engine ( version 1.2.3) and flexbe_app (2.2.2), some states of my own package are lost, as shown by Fig.1. Only one state is left.
Then I checkout flexbe_app (2.2.1) back, flexbe_behavior_engine is still in new version 1.2.3, states are complete, as shown by Fig.2.
new-version
Fig. 1

old-version
Fig. 2

Besides, Behaviors are always available, but they cannot work since some states disappear.
Will the new version be incompatible with the custom states?

@pschillinger
Copy link
Member

pschillinger commented Jan 12, 2020 via email

@zengxiaolei
Copy link
Author

I cannot be aware of the difference... Even the only left state "BehaviorGate" has nothing special. Here is the package: https://github.com/zengxiaolei/agv_behaviors
You can try yourself, please.

@pschillinger
Copy link
Member

Should be fixed by the above commit. It is not yet merged into master, but I will do a new release as soon as I have a more stable internet connection than on this train.

Problem was that you had states that have an entry in their documentation that is not correctly formatted, see e.g. diehl_a_or_b.py where <= done is stated in the docstring, but no text follows. This is normally not an issue, but will print a warning so that it can be tracked why there is no documentation for this outcome. Now, the bug here was that there was a failure during printing of this warning that stopped the further state parsing. This is fixed now and in addition robustified against similar problems.

@zengxiaolei
Copy link
Author

I tested your new commit, It works. Thanks a lot for your immediate reply.
Besides, I should and will make my state doc-string normative ;-)

@pschillinger
Copy link
Member

Has been fixed in 2.2.3

LoyVanBeek pushed a commit to LoyVanBeek/flexbe_app that referenced this issue Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants