Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

royalty fee manager tests #54

Closed
wants to merge 1 commit into from

Conversation

VictorONN
Copy link

Hello, tests for #36

3 tests appear to fail. The first two am the most odd since my approach is similar to the references :

  1. test_upgrade_with_class_hash_zero() fails even though the implementation is similar https://github.com/OpenZeppelin/cairo-contracts/blob/8372bc9ef2b4306cf02a60421e5d6843ebcd0c64/src/tests/upgrades/test_upgradeable.cairo#L35

  2. test_upgrade_event_when_successful() also fails despite following similar implementation https://github.com/OpenZeppelin/cairo-contracts/blob/8372bc9ef2b4306cf02a60421e5d6843ebcd0c64/src/tests/upgrades/test_upgradeable.cairo#L43

  3. And test_calculate_royalty_fee_and_get_recipient_success() fails with
    Failure data:
    Got an exception while executing a hint:
    Class hash 0x049b61ff596ba762ad66791c8204943217e5f1b94a28b34ce4ca2f9ad4ff2b6c is already declared

@Realkayzee
Copy link
Contributor

I will rectify this and make a new PR

@Realkayzee
Copy link
Contributor

@VictorONN I already worked on it and added it to my PR

@0xandee 0xandee closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants