Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, tests for #36
3 tests appear to fail. The first two am the most odd since my approach is similar to the references :
test_upgrade_with_class_hash_zero() fails even though the implementation is similar https://github.com/OpenZeppelin/cairo-contracts/blob/8372bc9ef2b4306cf02a60421e5d6843ebcd0c64/src/tests/upgrades/test_upgradeable.cairo#L35
test_upgrade_event_when_successful() also fails despite following similar implementation https://github.com/OpenZeppelin/cairo-contracts/blob/8372bc9ef2b4306cf02a60421e5d6843ebcd0c64/src/tests/upgrades/test_upgradeable.cairo#L43
And test_calculate_royalty_fee_and_get_recipient_success() fails with
Failure data:
Got an exception while executing a hint:
Class hash 0x049b61ff596ba762ad66791c8204943217e5f1b94a28b34ce4ca2f9ad4ff2b6c is already declared