Feat: added tests for signature checker functions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2024 14:17
|
Hi @psychiller do you mind have a check at the failed CI, really appreciate it! |
|
Fixed marketplace tests as well |
added 2 commits
January 21, 2024 20:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing tests, came across incorrect implementation of
validate_signature, i have fixed it.For testing, it was crucial to add
key_pairinMocksstruct to generate signature for orders, so i have added it as well to Mock struct, but it required to remove Serde attribute, as we were not serializing and deserializing it anywhere. If it is needed I can add it and find some other way to usekey_pairacross tests