Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a v2 of the eaglerforge mod #28

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

OeildeLynx31
Copy link

@OeildeLynx31 OeildeLynx31 commented Jun 19, 2024

Changes

[This version is currently not finished]

  1. Buttons in general
    The buttons are now:

    • Adapted according to the GUI size and the GUI scale factor
    • Showed only when necessary
  2. Keyboard buttons
    The keyboard buttons are now:

    • Placed according to their input field;
    • Giving the keyboard focus to the input when clicked on;
    • Multiple when necessary

image
image
image

  1. Control setting
    The control tab is disabled in the setting page to not be able to change keybinds, breaking Eaglermobile.
    image

Reason for changes

To better the user experience.

Tests

I don't have tested on iOS because I can't, but it works in android

P.S.:

There are some things to finish, like the in-game button position depending on it size.

@radmanplays
Copy link
Contributor

can you just change the original file instead of making a new one?

@OeildeLynx31
Copy link
Author

can you just change the original file instead of making a new one?

I did it from the normal version, and because it is not ready yet, I think it is better like this. But if you want particularly, I can change the original file only.

@FlamedDogo99
Copy link
Owner

If you continue to developed this, I would be open to devoting a branch to it. Can’t wait to see the finished product.

@OeildeLynx31
Copy link
Author

If you continue to developed this, I would be open to devoting a branch to it. Can’t wait to see the finished product.

Yes I continue! And I agree, it could be a good idea to create a special branch for it.

+ began to prepare the Mobile Control settings tab
@OeildeLynx31
Copy link
Author

Little update:

  • Fixed the button scale on some mobiles not working
  • Started to develop the mobile controls tab in the settings (more details here)

image
image

As an hybrid interface, based on Java & Javascript/HTML.
@OeildeLynx31
Copy link
Author

OeildeLynx31 commented Jun 21, 2024

Another little update:

  • Continued to implement the Mobile controls settings :
    Now it is a hybrid interface, with Java and Javascript&HTML working together.

image

The red square is the HTML div element, synchronized with the Java scrolling element.

@OeildeLynx31
Copy link
Author

I'll restart the dev of this project soon.

@radmanplays

This comment was marked as off-topic.

@OeildeLynx31
Copy link
Author

its been a week since your last comment

You're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants