Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Keyboard Fallback & Other Improvements #10

Merged
merged 38 commits into from
Jun 8, 2024
Merged

Android Keyboard Fallback & Other Improvements #10

merged 38 commits into from
Jun 8, 2024

Conversation

FlamedDogo99
Copy link
Owner

Big Changes!

Keyboard support (Android and iOS):

  • Added window.keyboardFix, which controls wether keydown or input events are used for keyboard capture.
  • Added input monitoring to seamlessly transition between window.keyboardFix states

Better keyEvent functions

  • Consolidated shiftKeyEvent(), deleteKeyEvent(), and keyEvent() into a single keyEvent function that supports more keys
  • All keyboardEvents should either be called through keyEvent() or set event.isValid to true to allow the input keyboard events to work

Fake pointerlock and fullscreen API

  • Pointerlock and the fullscreen API are read-only on some mobile devices, even though they had no functionality. This is now no longer the case

FlamedDogo99 added 30 commits June 3, 2024 13:53
@FlamedDogo99
Added android workaround
aed6d14 
Also I accidentally converted all the tabs to spaces, thus the large diff. I think this will be the standard from now on
@FlamedDogo99
Removing zoom on select
4139c5a
@FlamedDogo99
Hide input
6d60d94
@FlamedDogo99
Added position:absolute
fa12e9b
@FlamedDogo99
Hiding cursor
7ed4d29
@FlamedDogo99
Update version temporarily
d524fbb
@FlamedDogo99
Update eaglermobile.user.js
603e297
@FlamedDogo99
Added polyfill for apply and call
a4a9007 
I really hope this works
@FlamedDogo99
update version for testing
9ae89de
@FlamedDogo99
Last ditch-effort
0badfd6 
If this doesn’t work on android, I don’t know what will
@FlamedDogo99
Fixed keyboard override
5f9ebad 
Only injects code on keypress event listeners
@FlamedDogo99
Improved keyEvent function
916d730 
Removed shiftKeyEvent and deleteKeyEvent
@FlamedDogo99
Updated version for testing
180ac32
@FlamedDogo99
Updating toKeyCode function
5ae2833
@FlamedDogo99
Fixed comma issue
242e8d2
@FlamedDogo99
Replaced delete with backspace
4cfbd57
@FlamedDogo99
Added comments for keyEvent
5a17928
@FlamedDogo99
Updated from userscript
2ed6365
@FlamedDogo99
Auto detect keyboard issue
f5e7494 
First attempt:
hiddenInput saves the most recent value to window.lastKey
If we detect a keydown event with invalid key, keyCode or which, we enable window.keyboardFix, and redispatch the key from window.lastKey
The keyboard blocking function now checks for window.keyboardFix
@FlamedDogo99
Fixed equals sign
122d0e6
@FlamedDogo99
Fixed event handler
f80522a
@FlamedDogo99
Changing handler back?
3ec4bf6 
I keep getting an undefined error
@FlamedDogo99
Update eaglermobile.user.js
ea7ca0a
@FlamedDogo99
Fixed backspace crash
df6beea
@FlamedDogo99
Added extra “?”
1da8286
@FlamedDogo99
Moved keyboardFix event listener
69f8ded
@FlamedDogo99
Temporary fix for null weirdness
2930692 
I honestly have no idea
@FlamedDogo99
Fixed autodetect
4c5f3ad
@FlamedDogo99
Fixed error for window.lastKey
e382e2c
@FlamedDogo99
Fixed invalid key event
4846e06
@FlamedDogo99 FlamedDogo99 linked an issue Jun 7, 2024 that may be closed by this pull request
[Bug] Keyboard issue on Android mobile devices #7
Closed
@FlamedDogo99 FlamedDogo99 changed the title Keyboard fix Android Keyboard Fallback & Other Improvements Jun 7, 2024
@FlamedDogo99
Copy link
Owner Author

FlamedDogo99 commented Jun 7, 2024 •
edited
Loading

To-do:

  • Overhall readme.md with relevant information and documentation

@FlamedDogo99 FlamedDogo99 merged commit c45f40a into main Jun 8, 2024
@FlamedDogo99 FlamedDogo99 deleted the keyboard-fix branch June 8, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Keyboard issue on Android mobile devices
1 participant
@FlamedDogo99