Keyboard Button #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlamedDogo99
requested changes
May 28, 2024
eaglermobile.user.js
Outdated
| @@ -210,7 +219,10 @@ function insertCanvasElements() { | |||
| } | |||
| e.movementX = touch.pageX - previousX; | |||
| e.movementY = touch.pageY - previousY; | |||
| var evt = window.fakelock ? new MouseEvent("mousemove", {movementX: e.movementX, movementY: e.movementY}) : new WheelEvent("wheel", {"wheelDeltaY": e.movementY}); | |||
There was a problem hiding this comment.
This allows scrolling to work in menus, is there a reason this was removed?
There was a problem hiding this comment.
Oh i didn't realize
There was a problem hiding this comment.
No that should be added back
There was a problem hiding this comment.
Everything else besides that looks good. Good thinking with adding the mobile warning.
There was a problem hiding this comment.
I added it back in to the script
FlamedDogo99
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first tried this out i found it hard to actually add servers and name yourself so I added keyboard button
