Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect URL generated when copying invite link to clipboard #5223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: incorrect URL generated when copying invite link to clipboard #5223

wants to merge 1 commit into from

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes an issue identified when copying an invite link to the clipboard.

How did you test this code?

Ran the FE locally and verified that the URL copied matches the one shown.

@matthewelwell matthewelwell requested a review from a team as a code owner March 12, 2025 20:27
@matthewelwell matthewelwell requested review from tiagoapolo and removed request for a team March 12, 2025 20:27
@vercel Vercel
Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 8:27pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 8:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Mar 12, 2025 8:27pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 12, 2025
rolodato
rolodato approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly cursed how this is implemented but happy to fix it later, LGTM (famous last words)

@github-actions github-actions bot added the fix label Mar 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5223 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5223 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5223 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5223 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5223 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5223 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

Uffizzi Ephemeral Environment deployment-61828

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5223

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

@khvn26 khvn26 khvn26 approved these changes

@tiagoapolo tiagoapolo tiagoapolo approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewelwell @rolodato @khvn26 @tiagoapolo