-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python-types): Enforce static typing in api/app namespace #5216
base: main
Are you sure you want to change the base?
fix(python-types): Enforce static typing in api/app namespace #5216
Conversation
- handlers.py - pagination.py - utils.py - views.py
Added explicit None returns for readability.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
@mondaini is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Tested the following instructions:
|
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5216 +/- ##
==========================================
+ Coverage 97.51% 97.55% +0.03%
==========================================
Files 1227 1226 -1
Lines 42619 42604 -15
==========================================
+ Hits 41559 41561 +2
+ Misses 1060 1043 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mondaini and thanks a lot for your contribution.
It seems like your changes to api/app/handlers.py
don't pass the obligatory 100% patch coverage check. Good news is, as confirmed with the team, this code is not used and the file can be safely removed 👍
Alright! I'll remove it and get back to you! |
Done, @khvn26 |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Added missing type hints to core modules in
api/app/
:pagination.py
routers.py
views.py
utils.py
Removed unused file:
api/app/handler.py
as it's not being used in the codebaseKey improvements:
VersionInfoDict
)These changes will help catch type-related issues earlier in development and improve code maintainability.
How did you test this code?
Testing focused on ensuring type compliance:
api/app
namespace