-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot use an API Key to add users to a group #4362
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/users/views.py
Did you find this useful? React with a 👍 or 👎 |
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4362 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 1162 1162
Lines 38239 38248 +9
=======================================
+ Hits 37012 37021 +9
Misses 1227 1227 ☔ View full report in Codecov by Sentry. |
Can we accommodate |
Well, strictly, that would involve changing the branch name and recreating the PR, etc. - I can do it, but at that point, we might as well just create a new PR? |
Hence 'strictly'. It's ugly to not change the branch name, but I can. I guess the branch name doesn't live anywhere post merge so it's fine. I'll just do it, yep. |
Actually @khvn26, sorry, but no, #4370 is actually quite a bit more involved as it breaks the webhook schema. If you look here, we're currently always sending the email of the user that made the change. We will no longer have that option available to us. Based on this, I'd say it definitely deserves its own PR. |
Changes
Fixes #4361
How did you test this code?
Added a new test for the specific failure case and also updated the test module to use admin_client_new in all tests and resolved any other similar issues.