Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Manage user's groups #4312

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Manage user's groups #4312

wants to merge 2 commits into from
+169 −3

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Todo: the API needs to return group_admin in /organisations/:id/groups for this to function correctly

image

How did you test this code?

Viewed / adjusted user permissions

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 9, 2024 09:25
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team July 9, 2024 09:25
@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:33am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:33am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 9:33am

@kyle-ssg kyle-ssg requested a review from khvn26 July 9, 2024 09:26
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jul 9, 2024
@kyle-ssg kyle-ssg marked this pull request as draft July 9, 2024 09:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4312 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4312 Finished ✅ Skipped

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4312 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4312 Finished ✅ Results ✅

@kyle-ssg kyle-ssg mentioned this pull request Jul 9, 2024
Open
@kyle-ssg kyle-ssg linked an issue Jul 9, 2024 that may be closed by this pull request
Add a convenient permissions view for group/project/organisation admins #4269
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Uffizzi Ephemeral Environment deployment-53983

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4312

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa Awaiting requested review from novakzaballa novakzaballa is a code owner automatically assigned from Flagsmith/flagsmith-front-end

@khvn26 khvn26 Awaiting requested review from khvn26

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a convenient permissions view for group/project/organisation admins
1 participant
@kyle-ssg