fix: feature-specific segments link

[kyle-ssg]

Thanks for submitting a PR! Please check the boxes below:

• I have run pre-commit to check linting
• I have added information to docs/ if required so people know about the feature!
• I have filled in the "Changes" section below?
• I have filled in the "How did you test this code" section below?
• I have used a Conventional Commit title for this Pull Request

Changes

Fixes urls to a feature-specific segment.

How did you test this code?

• Refreshed a url to a feature-specific segment

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2024 9:39am
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2024 9:39am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		Aug 28, 2024 9:39am

[github-actions]

flagsmith image build and security scan finished ✨

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith:pr-4299	Finished ✅	Results ✅

[github-actions]

flagsmith-api image build and security scan finished ✨

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-api:pr-4299	Finished ✅	Results ✅

[github-actions]

flagsmith-e2e image build finished ✨

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4299	Finished ✅	Skipped

[github-actions]

flagsmith-frontend image build and security scan finished ✨

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4299	Finished ✅	Results ✅

[github-actions]

flagsmith-private-cloud image build and security scan finished ✨

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4299	Finished ✅	Results ✅

[github-actions]

Uffizzi Preview deployment-53958 was deleted.

[rolodato]

This does fix links to feature-specific segments, but it does not enable the "Include Feature-Specific" option. Is that feasible to do as well?

My reasoning is that if you open a link to a segment, there's nothing in the segment itself or the URL that tells you it's feature-specific. If you close the modal intentionally or accidentally, it's more difficult to go back to where you were - especially considering that segment modals do not add browser history, so you can't use Back to re-open them after closing.

Also suggest a different title: fix: Fix links to feature-specific segments not opening the segment details modal

[kyle-ssg]

Ok if that's the usecase then it can only be solved by the modal being url based in the history, since segments are paged.

I've adjusted the behaviour such that the user can go back and forward in browser history

[github-actions]

Docker builds report

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4299	Finished ✅	Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4299	Finished ✅	Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4299	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith:pr-4299	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4299	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4299	Finished ✅	Results ✅

[rolodato]

@kyle-ssg thanks for the update, I'm able to use browser navigation to get back to a closed segment modal now.

One last thing - would it be feasible to have the "Include Feature-Specific" option pre-selected if they open a link to a feature-specific segment? My reasoning is that, to get to a feature-specific segment from the Segments page, you need to have selected the "Include Feature-Specific" option at some point. Having it enabled when you open a link to a feature-specific segment seems more consistent with the navigation behaviour.

[kyle-ssg]

Done @rolodato

[rolodato]

@kyle-ssg I see we're including the featureSpecific URL parameter but it's not automatically added when opening a feature-specific segment if the parameter isn't already there.

This is definitely better than what we have now, but I was hoping to have this parameter added automatically if it's not there. For example, this URL is for a feature-specific segment:

https://flagsmith-frontend-staging-gui9akkrb-flagsmith.vercel.app/project/6605/segments?id=9766

which ends up as:

https://flagsmith-frontend-staging-gui9akkrb-flagsmith.vercel.app/project/6605/segments?id=9766&featureSpecific=false

Instead, I was expecting:

https://flagsmith-frontend-staging-gui9akkrb-flagsmith.vercel.app/project/6605/segments?id=9766&featureSpecific=true

[kyle-ssg]

@kyle-ssg I see we're including the featureSpecific URL parameter but it's not automatically added when opening a feature-specific segment if the parameter isn't already there.

I'm not sure how they'd get the url with a missing parameter to begin with. Regardless, this will now update based on the fetched segment.

[rolodato]

It works! One last thing which I'm not sure was present before, is that toggling "Include Feature-Specific" changes the URL and adds a history entry, but navigating back/forward does not actually reflect this change in the page.

IMO toggling "Include Feature-Specific" should not add a history change, whether that happens through interaction or not. Or, it should add a history entry but reflect the state change correctly, but I would prefer the former option.

Screen.Recording.2024-08-28.at.08.58.47.mov

[kyle-ssg]

In the interest of not keeping PRs around for weeks on end, I've merged this for now. I can adjust the behaviour of this at a later date