Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timestamps to segments models #4236

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds timestamps to segments module models. Includes code to nullify the timestamps for existing records.

How did you test this code?

Checked the database changes when running locally and verified that they're properly set.

@zachaysan zachaysan requested a review from a team as a code owner June 25, 2024 20:05
@zachaysan zachaysan requested review from khvn26 and removed request for a team June 25, 2024 20:05
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:38pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:38pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:38pm

@zachaysan zachaysan requested review from matthewelwell and removed request for khvn26 June 25, 2024 20:05
@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 25, 2024
Copy link
Contributor

github-actions bot commented Jun 25, 2024

Uffizzi Preview deployment-53494 was deleted.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (bc9b340) to head (d3b6abb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4236   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files        1194     1195    +1     
  Lines       39071    39094   +23     
=======================================
+ Hits        37745    37768   +23     
  Misses       1326     1326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 27, 2024
novakzaballa

This comment was marked as resolved.

@novakzaballa novakzaballa dismissed their stale review June 27, 2024 20:45

I have a doubt.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaysan zachaysan added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit a5b2421 Jun 28, 2024
28 checks passed
@zachaysan zachaysan deleted the feat/add_timestamps_to_segments_models branch June 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants