Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use combined version endpoint #4050

Closed
wants to merge 11 commits into from
Closed

chore: use combined version endpoint #4050

wants to merge 11 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented May 29, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This adjusts the frontend to use a single endpoint for creating a version.

How did you test this code?

  • Created / updated versions
  • Created change requests with multiple segment override / standard version updates

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 1:59pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 1:59pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 1:59pm

@kyle-ssg kyle-ssg marked this pull request as draft May 29, 2024 17:31
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 29, 2024 •
edited
Loading

Uffizzi Preview deployment-52405 was deleted.

@kyle-ssg
Merge branch 'refs/heads/main' into chore/use-combined-version-endpoint
eff3f6c 
# Conflicts:
#	frontend/common/services/useFeatureVersion.ts
#	frontend/common/types/requests.ts
@kyle-ssg
Conflicts
c50a56d
@github-actions github-actions bot added the chore label Jun 13, 2024
@github-actions github-actions bot added chore and removed chore labels Jun 21, 2024
@matthewelwell matthewelwell mentioned this pull request Jun 21, 2024
Merged
5 tasks
@matthewelwell
Copy link
Contributor

I've tested this against the Uffizzi deployment built for the API PR here and confirmed that it seems to work as expected. More detail available on this comment.

@kyle-ssg I think this PR can be marked as ready for review (although the description needs updating too)?

@matthewelwell
Copy link
Contributor

The API has now been merged to main and deployed to staging so we should be able to test this using the preview against staging.

@kyle-ssg kyle-ssg marked this pull request as ready for review June 24, 2024 16:19
@kyle-ssg kyle-ssg requested a review from a team as a code owner June 24, 2024 16:19
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team June 24, 2024 16:19
@github-actions github-actions bot removed the chore label Jun 24, 2024
@github-actions github-actions bot added the chore label Jun 24, 2024
@github-actions github-actions bot added chore and removed chore labels Jul 3, 2024
@github-actions github-actions bot added chore and removed chore labels Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4050 Finished ✅ Skipped

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4050 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4050 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4050 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4050 Finished ✅ Results ✅

@github-actions github-actions bot added chore and removed chore labels Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4050 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4050 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4050 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4050 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4050 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4050 Finished ✅ Results ✅

@matthewelwell
Copy link
Contributor

Superseded by #4301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyle-ssg @matthewelwell @novakzaballa