Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tags for GitHub integration FE #4035

Merged
merged 6 commits into from
Aug 12, 2024
Merged

feat: Add tags for GitHub integration FE #4035

merged 6 commits into from
Aug 12, 2024

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented May 27, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Enable tagging and labeling:

Screenshot 2024-08-07 at 3 02 32 PM

Add tags for GitHub integrations in the FE

Screenshot 2024-05-27 at 9 19 10 AM Screenshot 2024-05-27 at 5 50 42 PM

Add label in the Issue/PR

Screenshot 2024-08-07 at 3 50 24 PM

How did you test this code?

@vercel Vercel
Copy link

vercel bot commented May 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 7:38pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 7:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 7:38pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 27, 2024 •
edited
Loading

Uffizzi Preview deployment-55125 was deleted.

@novakzaballa novakzaballa changed the title WIP: feat: Add tags for GitHub integration FE feat: Add tags for GitHub integration FE - WIP May 28, 2024
@novakzaballa novakzaballa mentioned this pull request May 28, 2024
Merged
5 tasks
@novakzaballa novakzaballa changed the title feat: Add tags for GitHub integration FE - WIP feat: Add tags for GitHub integration FE May 28, 2024
@github-actions github-actions bot added the feature New feature or request label Jun 4, 2024
@novakzaballa novakzaballa marked this pull request as draft June 20, 2024 20:23
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 27, 2024
@novakzaballa novakzaballa marked this pull request as ready for review July 4, 2024 15:42
@novakzaballa novakzaballa requested a review from a team as a code owner July 4, 2024 15:42
@novakzaballa novakzaballa requested review from kyle-ssg and removed request for a team July 4, 2024 15:42
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 4, 2024
@github-actions github-actions bot removed the feature New feature or request label Jul 4, 2024
@github-actions github-actions bot added the feature New feature or request label Jul 4, 2024
@kyle-ssg
Copy link
Member

kyle-ssg commented Jul 24, 2024 •
edited
Loading

image

  • PR_CLOSED is all caps vs others
  • pr linked should probably be PR Open ?

image

  • Should the icons be 14px like the lock ?

kyle-ssg
kyle-ssg reviewed Aug 7, 2024
View reviewed changes
frontend/common/useInfiniteScroll.ts Outdated
@@ -70,6 +76,7 @@ const useInfiniteScroll = <
isLoading: queryResponse.isLoading,
loadMore,
loadingCombinedData: loadingCombinedData && queryResponse.isFetching,
refetchData,
Copy link
Member

@kyle-ssg kyle-ssg Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might get confusing with refresh. If it's not doing what we want (I guess you want to set page to 1 + refetch) then we should do that I think unless the purpose is to refetch preserving the current filter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected the refresh function and removed the refetchData function.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4035 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4035 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4035 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4035 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4035 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4035 Finished ✅ Results ✅

@novakzaballa novakzaballa added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 3c46a31 Aug 12, 2024
31 checks passed
@novakzaballa novakzaballa deleted the feat/add-tags-for-github-integration-fe branch August 12, 2024 13:34
@flagsmithdev flagsmithdev mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novakzaballa @kyle-ssg