Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support transient identities and traits #158

Merged
merged 4 commits into from
Aug 30, 2024
Merged

feat: Support transient identities and traits #158

merged 4 commits into from
Aug 30, 2024

Conversation

novakzaballa
Copy link
Contributor

Closes #156

@novakzaballa novakzaballa requested review from a team, matthewelwell and khvn26 and removed request for a team July 26, 2024 18:40
khvn26
khvn26 requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a number of problems fixed before I approve.

tests/sdk/utils.ts Outdated Show resolved Hide resolved
sdk/utils.ts Outdated Show resolved Hide resolved
sdk/utils.ts Outdated Show resolved Hide resolved
sdk/index.ts Outdated Show resolved Hide resolved
sdk/utils.ts Outdated Show resolved Hide resolved
tests/sdk/flagsmith-identity-flags.test.ts Outdated Show resolved Hide resolved
flagsmith-engine/identities/models.ts Outdated Show resolved Hide resolved
flagsmith-engine/identities/traits/models.ts Outdated Show resolved Hide resolved
@novakzaballa novakzaballa requested a review from khvn26 August 5, 2024 13:13
khvn26
khvn26 requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one error, proposed one test improvement to guard against said error, and two less important suggestions.

flagsmith-engine/identities/traits/models.ts Outdated Show resolved Hide resolved
sdk/utils.ts Outdated Show resolved Hide resolved
sdk/utils.ts Outdated Show resolved Hide resolved
tests/sdk/flagsmith-identity-flags.test.ts Outdated Show resolved Hide resolved
@novakzaballa novakzaballa requested a review from khvn26 August 7, 2024 16:49
@matthewelwell matthewelwell removed their request for review August 22, 2024 09:59
@khvn26 khvn26 changed the title feat: transient identities and traits feat: Support transient identities and traits Aug 30, 2024
@khvn26 khvn26 merged commit 2b5df9f into main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support transient identities and traits
2 participants
@novakzaballa @khvn26