fix: error evaluating CONTAINS / NOT_CONTAINS for null traits #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
novakzaballa
and removed request for
a team
renovate bot
referenced
this pull request
in open-feature/playground
Jul 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [flagsmith-nodejs](http://flagsmith.com/) ([source](https://togithub.com/Flagsmith/flagsmith-nodejs-client)) | [`3.3.0` -> `3.3.3`](https://renovatebot.com/diffs/npm/flagsmith-nodejs/3.3.0/3.3.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Flagsmith/flagsmith-nodejs-client (flagsmith-nodejs)</summary> ### [`v3.3.3`](https://togithub.com/Flagsmith/flagsmith-nodejs-client/releases/tag/v3.3.3) [Compare Source](https://togithub.com/Flagsmith/flagsmith-nodejs-client/compare/v3.3.2...v3.3.3) #### What's Changed - Cancel timeout when it is no longer needed by [@​wheineman-sunrun](https://togithub.com/wheineman-sunrun) in [https://github.com/Flagsmith/flagsmith-nodejs-client/pull/141](https://togithub.com/Flagsmith/flagsmith-nodejs-client/pull/141) #### New Contributors - [@​wheineman-sunrun](https://togithub.com/wheineman-sunrun) made their first contribution in [https://github.com/Flagsmith/flagsmith-nodejs-client/pull/141](https://togithub.com/Flagsmith/flagsmith-nodejs-client/pull/141) **Full Changelog**: Flagsmith/flagsmith-nodejs-client@v3.3.2...v3.3.3 ### [`v3.3.2`](https://togithub.com/Flagsmith/flagsmith-nodejs-client/releases/tag/v3.3.2) [Compare Source](https://togithub.com/Flagsmith/flagsmith-nodejs-client/compare/v3.3.1...v3.3.2) #### What's Changed - fix: handle null traits for regex evaluations by [@​matthewelwell](https://togithub.com/matthewelwell) in [https://github.com/Flagsmith/flagsmith-nodejs-client/pull/152](https://togithub.com/Flagsmith/flagsmith-nodejs-client/pull/152) **Full Changelog**: Flagsmith/flagsmith-nodejs-client@v3.3.1...v3.3.2 ### [`v3.3.1`](https://togithub.com/Flagsmith/flagsmith-nodejs-client/releases/tag/v3.3.1) [Compare Source](https://togithub.com/Flagsmith/flagsmith-nodejs-client/compare/v3.3.0...v3.3.1) #### What's Changed - fix: only flush analytics once if requested concurrently by [@​rolodato](https://togithub.com/rolodato) in [https://github.com/Flagsmith/flagsmith-nodejs-client/pull/148](https://togithub.com/Flagsmith/flagsmith-nodejs-client/pull/148) - fix: error evaluating CONTAINS / NOT_CONTAINS for null traits by [@​matthewelwell](https://togithub.com/matthewelwell) in [https://github.com/Flagsmith/flagsmith-nodejs-client/pull/150](https://togithub.com/Flagsmith/flagsmith-nodejs-client/pull/150) - Bump version 3.3.1 by [@​matthewelwell](https://togithub.com/matthewelwell) in [https://github.com/Flagsmith/flagsmith-nodejs-client/pull/151](https://togithub.com/Flagsmith/flagsmith-nodejs-client/pull/151) #### New Contributors - [@​rolodato](https://togithub.com/rolodato) made their first contribution in [https://github.com/Flagsmith/flagsmith-nodejs-client/pull/148](https://togithub.com/Flagsmith/flagsmith-nodejs-client/pull/148) **Full Changelog**: Flagsmith/flagsmith-nodejs-client@v3.3.0...v3.3.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/playground). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #149 .
Note that in keeping with the python engine implementation, I ensured that
NOT_CONTAINSreturns false for non string values.