OPS-3896 #34
Merged
OPS-3896 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 10, 2020 11:52
runderwoodcr14
requested review from
danvaida,
zxpower,
snovikov,
ronny-panknin-flaconi and
vikkasyousaf
danvaida
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
I trust @runderwoodcr14 to have checked the changelog of each and every of those external resources and ensure that there is no difference when it comes to inputs and outputs 😄
| @@ -13,7 +13,7 @@ resource "null_resource" "dynamodb3_checker" { | |||
|
|
|||
| module "dynamodb3" { | |||
There was a problem hiding this comment.
Funny how I have absolutely zero clue what the heck dynamodb_2 or dynamodb_3 means 😄
Man if you are going to ask those kind of things here is no fun for deploying in production then 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump modules versions to be compatible with aws provider 3.X.X also updated examples, changed makefile to use terraform verision 0.12.29 as ver was using light and light uses latest release available in this case 0.13.x
terraform-aws-rds
cloudposse dynamodb